This macro can be defined in some global header, or better, as a compiler comman

Question

This macro can be defined in some global header, or better, as a compiler command line parameter:

#define me (*this)
And some usage example:

some_header.h:

inline void Update()
{
    /* ... */
}
main.cpp:

#include "some_header.h"

class A {
public:
    void SetX(int x)
    {
        me.x = x;
        me.Update();
    }

    void SomeOtherFunction()
    {
        ::Update();
    }

    /*
        100 or more lines
        ...
    */

    void Update()
    {
        // ...
    }

    int x;
};
So in a class method when I access a class member, I am always using me, and when accessing a global identifier I always use ::. This gives the reader which is not familiar with the code (probably myself after a few months) localized information of what is accessed without the need to look somewhere else. I want to define me because I find using this-> everywhere too noisy and ugly. But can #define me (*this) be considered a good C++ practice? Are there some practical problematic points with the me macro? And if you as C++ programmer will be the reader of some code using the me macro, would you like it or not?

Explanation / Answer

No, it is not.

Mind the programmer who will maintain your code several years from now long after you've left for greener pastures and follow common conventions of the language you use. In C++, you almost never have to write this, because the class is included in symbol resolution order and when a symbol is found in class scope, this-> is implied. So just don't write it like everybody does.

If you often get confused which symbols come from class scope, the usual approach is using common naming pattern for members (fields and sometimes private methods; I haven't seen it used for public methods). Common ones include suffixing with _ or prefixing with m_ or m.

Related Questions

Navigate

• Browse (All)
• Browse T
• Subjects

Integrity-first tutoring: explanations and feedback only — we do not complete graded work. Learn more.