I was looking for some more input regarding this C# code and any input I can get

Question

I was looking for some more input regarding this C# code and any input I can get if I need to change or improve anything.

class Program
{
static void Main(string[] args)
{
Char guessedletter1 = 's';
Char guessedletter2 = 't';
Char guessedletter3 = 'i';
Char guessedletter4 = 'n';
Char guessedletter5 = 's';
Char guessedletter6 = 'o';
Char guessedletter7 = 'n';

Char Input;
int InvalidCount;
InvalidCount = 0;

WelcomeMessage();
Input = GetInput();
if (!CheckInput(Input, guessedletter1, guessedletter2, guessedletter3, guessedletter4, guessedletter5, guessedletter6, guessedletter7) == true)
{
InvalidCount = InvalidCount + 1;
}

Input = GetInput();
if (!CheckInput(Input, guessedletter1, guessedletter2, guessedletter3, guessedletter4, guessedletter5, guessedletter6, guessedletter7) == true)
{
InvalidCount = InvalidCount + 1;
}

Input = GetInput();
if (!CheckInput(Input, guessedletter1, guessedletter2, guessedletter3, guessedletter4, guessedletter5, guessedletter6, guessedletter7) == true)
{
InvalidCount = InvalidCount + 1;
}

Input = GetInput();
if (!CheckInput(Input, guessedletter1, guessedletter2, guessedletter3, guessedletter4, guessedletter5, guessedletter6, guessedletter7) == true)
{
InvalidCount = InvalidCount + 1;
}

Input = GetInput();
if(!CheckInput(Input, guessedletter1, guessedletter2, guessedletter3, guessedletter4, guessedletter5, guessedletter6, guessedletter7) == true)
{
InvalidCount = InvalidCount + 1;
}

Input = GetInput();
if (!CheckInput(Input, guessedletter1, guessedletter2, guessedletter3, guessedletter4, guessedletter5, guessedletter6, guessedletter7) == true)
{
InvalidCount = InvalidCount + 1;
}

Input = GetInput();
if (!CheckInput(Input, guessedletter1, guessedletter2, guessedletter3, guessedletter4, guessedletter5, guessedletter6, guessedletter7) == true)
{
InvalidCount = InvalidCount + 1;
}

Console.WriteLine("");
Console.WriteLine("Your score is: " + InvalidCount.ToString());

Console.Write("Press any key to continue...");
Console.ReadKey();
}

private static Boolean CheckInput(char Input, char guessedletter1, char guessedletter2, char guessedletter3, char guessedletter4, char guessedletter5, char guessedletter6, char guessedletter7)
{
if (Input == guessedletter1 || Input == guessedletter2 || Input == guessedletter3 || Input == guessedletter4 || Input == guessedletter5 || Input == guessedletter6 || Input == guessedletter7)
{
Console.WriteLine("You guessed a letter correctly!");
Console.WriteLine("");
return true;
}

Console.WriteLine("You guessed incorrectly!");
Console.WriteLine("");
return false;
}

private static char GetInput()
{
Console.Write("Enter a letter please: ");
ConsoleKeyInfo ckInfo = Console.ReadKey();
Console.WriteLine("");
return ckInfo.KeyChar;
}

private static void WelcomeMessage()
{
Console.WriteLine("************************************************************");
Console.WriteLine("*********************** WEEK 5 *****************************");
Console.WriteLine("************************************************************");
Console.WriteLine("");
}
}
}

Explanation / Answer

Have proper indentation of the code.

It's very hard to read unindented code.

Comment each and every funtion of program, explaining what is the motive of the function in this program. This way, your code will become more readable and maintainable.

Related Questions

Navigate

• Browse (All)
• Browse I
• Subjects

Integrity-first tutoring: explanations and feedback only — we do not complete graded work. Learn more.